[Gecode] Diff between gecode head and gecode fs branch merged withhead

[Gabor Szokoli]

Christian Schulte wrote:

>Some quick questions:
> - Why did you change the use of Arith::max (and min)? Don't, Arith::max and
>min avoid branching.
>  
>
They give unexpected results for integers that are big.
We can change back, but we have to figure out in what range they work, 
and limit domains of variables to be smaller than that.

> - Please adhere to the indentation style as used elsewhere (so we can all
>read easily)
>  
>
2 spaces instead of tabs, right?
Do you use any automatic code formatter/beautifyer?

> - NEVER USE MALLOC! Please use Memory::alloc (that gives us central control
>over allocation)
>  
>
We'll look at the allocation of the dummy varmodboard again.

> - Why have <iostream> in the kernel? If you used for testing, remove.
>
>  
>
Because I am forgetful. (And dependent on a little button titled 
"Organise Imports" my current IDE does not have :-)  ) Sorry.

>That's it. 
>
>Christian
>
>--
>Christian Schulte, http://www.imit.kth.se/~schulte/ 
>
>-----Original Message-----
>From: gecode-bounces at ps.uni-sb.de [mailto:gecode-bounces at ps.uni-sb.de] On
>Behalf Of Gabor Szokoli
>Sent: Thursday, April 01, 2004 5:41 PM
>To: gecode at ps.uni-sb.de
>Subject: [Gecode] Diff between gecode head and gecode fs branch merged
>withhead
>
>
>Hi!
>
>Here's a diff between the current head, and what would be in CVS if we 
>decided to merge.
>Except gcc has issues with some of the examples that use the new 
>ArgArray interface, and our examples do not compile because they use the 
>old one.
>The merge itself was automatic, painless, but we have not tried if it 
>still works yet, compiles "just as good" as the head.
>
>It's 70KB, should fit in everyones mailbox unless some people have 
>friends with a strange sense of humor on April 1st.
>Most of it is the Alice binding though as our new files were omitted. 
>(the whole fs subdirectory)
>
>$ diff -r -x CVS -I "\*[ ]*\\$" gecodeHead gecode >difference
>
>
>
>_______________________________________________
>Gecode mailing list
>Gecode at ps.uni-sb.de
>http://www.ps.uni-sb.de/mailman/listinfo/gecode
>  
>